Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

relay/streamer: move binlog log reader into relay #2270

Closed
wants to merge 7 commits into from
Closed

relay/streamer: move binlog log reader into relay #2270

wants to merge 7 commits into from

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

it's first part of subtask 4 in #2214

no code logic change in this pr, to make review/merge easier

What is changed and how it works?

  • move binlog log reader into relay
  • flat small sub packages
  • rename some structs to avoid conflict

Check List

no code logic change

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the contribution For contributor label Oct 27, 2021
@ti-chi-bot
Copy link
Member

@D3Hunter: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter D3Hunter closed this Nov 1, 2021
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Nov 1, 2021

closed, move to ticdc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 Awaiting requested review from lance6716

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
contribution For contributor needs-rebase size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D3Hunter @ti-chi-bot